Child pages
  • uPortal IRC Logs-2012-04-30
Skip to end of metadata
Go to start of metadata

[10:03:56 CDT(-0500)] <EricDalquist> so sass-maven-plugin is done athena

[10:04:09 CDT(-0500)] <athena> yay!!

[10:04:13 CDT(-0500)] <athena> that's awesome (smile)

[10:04:18 CDT(-0500)] <EricDalquist> posted some questions to the list

[10:04:20 CDT(-0500)] <athena> it working well w/ our current setup?

[10:04:21 CDT(-0500)] <athena> ah ok

[10:04:27 CDT(-0500)] <EricDalquist> the biggest being … do we delete the .css files from git

[10:04:35 CDT(-0500)] <EricDalquist> and just generate them at build time

[10:04:44 CDT(-0500)] <EricDalquist> but if you could take a look at that email and let me know

[10:05:04 CDT(-0500)] <athena> yeah

[10:05:06 CDT(-0500)] <athena> just glanced over it

[10:05:23 CDT(-0500)] <athena> my suggestion is we delete the css from git and document really well how to change it back, ig uess

[10:05:27 CDT(-0500)] <athena> but want to see community feedback

[10:05:36 CDT(-0500)] <EricDalquist> if we do build-time generation I'm guessing we'll need to do a little work on the resource server plugin

[10:05:48 CDT(-0500)] <EricDalquist> since that looks for the css in the source dir

[10:06:16 CDT(-0500)] <athena> can you try running the script w/ the "expanded" option?

[10:06:19 CDT(-0500)] <athena> that might be part of the formatting

[10:06:26 CDT(-0500)] <athena> that makes sense

[10:06:34 CDT(-0500)] <EricDalquist> sure

[10:10:39 CDT(-0500)] <EricDalquist> having all this scripting lanaguages available via java is handy though

[10:15:05 CDT(-0500)] <EricDalquist> that was it

[10:15:16 CDT(-0500)] <EricDalquist> changed the style to expanded and it works

[10:16:55 CDT(-0500)] <athena> oh great!

[10:16:55 CDT(-0500)] <athena> ok

[10:16:57 CDT(-0500)] <EricDalquist> so if we ditch the .css files in git

[10:17:14 CDT(-0500)] <EricDalquist> then I think we bind the sass maven plugin to generate-resources

[10:17:28 CDT(-0500)] <athena> then we can look for the stuff in target?

[10:17:33 CDT(-0500)] <EricDalquist> yeah

[10:17:42 CDT(-0500)] <EricDalquist> I'll have to look at the resource server plugin

[10:17:52 CDT(-0500)] <EricDalquist> and see if it is configurable enough as is

[10:17:55 CDT(-0500)] <EricDalquist> or if we need more work

[10:18:10 CDT(-0500)] <EricDalquist> I'm looking at http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Lifecycle_Reference

[10:18:32 CDT(-0500)] <EricDalquist> so it looks like we actually bind the resource-server-plugin to prepare-package

[10:19:18 CDT(-0500)] <EricDalquist> I'm guessing I did that so that we didn't have to wait for the skin compile every time we built

[10:19:27 CDT(-0500)] <EricDalquist> so maybe we bind this SCSS->CSS to prepare-package too

[10:19:36 CDT(-0500)] <EricDalquist> and just have it listed before resource-server so it runs first

[10:22:40 CDT(-0500)] <athena> makes sense to me (smile)

[10:22:56 CDT(-0500)] <EricDalquist> I'll see if I can make that work on the branch

[10:23:07 CDT(-0500)] <athena> we'll also want to document how to get sass to run and copy files to the deployed portal during development

[10:23:13 CDT(-0500)] <athena> think peter should be able to help w/ that

[10:23:14 CDT(-0500)] <EricDalquist> the hardest part of that plugin was that I've never run sass before (tongue)

[10:23:19 CDT(-0500)] <athena> yeah (tongue)

[10:23:34 CDT(-0500)] <EricDalquist> peter's pull on friday really helped though

[10:25:03 CDT(-0500)] <athena> oh that's great

[10:25:09 CDT(-0500)] <athena> and i'm so glad you were able to write the plugin

[10:25:19 CDT(-0500)] <athena> i've actually been sort of worried about this in the back of my mind for a while

[10:25:47 CDT(-0500)] <EricDalquist> https://github.com/Jasig/sass-maven-plugin/blob/master/src/main/java/org/jasig/maven/plugin/sass/SassCompilerMojo.java

[10:25:51 CDT(-0500)] <EricDalquist> that is the entire thing

[10:26:56 CDT(-0500)] <EricDalquist> yeah looks like resource server plugin needs some TLC to get this working

[10:38:38 CDT(-0500)] <athena> ah

[13:47:42 CDT(-0500)] <EricDalquist> peterjhart: thanks for the SASS cleanup

[13:47:47 CDT(-0500)] <EricDalquist> made getting the maven plugin working much easier

[14:14:39 CDT(-0500)] <peterjhart> sweet

[14:15:09 CDT(-0500)] <peterjhart> is the maven plugin complete?

[14:16:32 CDT(-0500)] <EricDalquist> yes

[14:16:34 CDT(-0500)] <EricDalquist> brb

[14:20:21 CDT(-0500)] <EricDalquist> well it is functional

[14:20:25 CDT(-0500)] <EricDalquist> I need to cut a release of it

[14:20:35 CDT(-0500)] <EricDalquist> but I was going to wait on that until I figure out some other changes

[14:20:45 CDT(-0500)] <EricDalquist> we have to tweak the aggregator plugin

[14:20:52 CDT(-0500)] <EricDalquist> to play nice with the sass plugin

[14:23:26 CDT(-0500)] <peterjhart> cool

[14:23:27 CDT(-0500)] <peterjhart> in sass we have been using the "expanded" style

[14:23:32 CDT(-0500)] <EricDalquist> yup

[14:23:33 CDT(-0500)] <peterjhart> setting

[14:23:39 CDT(-0500)] <EricDalquist> jen piinted that out to me

[14:23:46 CDT(-0500)] <EricDalquist> and I fixed it as the default in the plugin

[14:23:54 CDT(-0500)] <peterjhart> k

[15:38:20 CDT(-0500)] <EricDalquist> oi … we are seriously overloading the number of things being done during prepare-package

[15:40:06 CDT(-0500)] <EricDalquist> also it looks like the resource aggr plugin is good as is

[15:40:17 CDT(-0500)] <EricDalquist> I think I have build-time generation of CSS from SASS working

[16:11:23 CDT(-0500)] <EricDalquist> athena: you there?

[16:12:16 CDT(-0500)] <athena> yep

[16:12:38 CDT(-0500)] <EricDalquist> I just noticed when testing this skin scss/aggr stuff that there are a few .css files geting loaded via @Import

[16:12:54 CDT(-0500)] <EricDalquist> that are not minified or have good caching headers

[16:12:58 CDT(-0500)] <athena> ick!

[16:13:04 CDT(-0500)] <athena> that sounds like somethign that should get fixed

[16:13:06 CDT(-0500)] <EricDalquist> fss-framework-1.4.0.css has a few

[16:13:07 CDT(-0500)] <athena> which files are they?

[16:13:12 CDT(-0500)] <EricDalquist> @import url('fss-reset-global.css');@import url('fss-base-global.css');

[16:13:13 CDT(-0500)] <athena> oh, hmm.

[16:13:26 CDT(-0500)] <athena> we probably don't even have those files

[16:13:42 CDT(-0500)] <athena> interesting.

[16:13:42 CDT(-0500)] <EricDalquist> we do

[16:13:45 CDT(-0500)] <EricDalquist> they are loading correctly

[16:13:51 CDT(-0500)] <athena> huh

[16:13:56 CDT(-0500)] <EricDalquist> so I haven;'t tracked down all the imports yet

[16:13:58 CDT(-0500)] <EricDalquist> but I see

[16:14:00 CDT(-0500)] <athena> our intention is to have all the fluid stuff concatenated, i think

[16:14:22 CDT(-0500)] <EricDalquist> fss-base-global.css, fss-reset-global.css, and styles.css all coming in uncompreseed

[16:14:31 CDT(-0500)] <athena> that's weird - i've never actually noticed that

[16:15:04 CDT(-0500)] <athena> is that the common fluid import?

[16:15:13 CDT(-0500)] <athena> i guess we'll need to do some reorganization

[16:15:49 CDT(-0500)] <EricDalquist> styles.css seems to be one of ours

[16:16:02 CDT(-0500)] <athena> which file is that included from?

[16:16:07 CDT(-0500)] <EricDalquist> still looking ...

[16:16:37 CDT(-0500)] <EricDalquist> I'm not sure ...

[16:18:03 CDT(-0500)] <athena> ok, looks like its in our fluid.fss.css file

[16:18:07 CDT(-0500)] <athena> so:

[16:18:09 CDT(-0500)] <athena> 1. that needs fixing

[16:18:13 CDT(-0500)] <athena> and

[16:18:25 CDT(-0500)] <athena> 2. we need to restructure the fluid fss

[16:18:38 CDT(-0500)] <EricDalquist> ok

[16:18:43 CDT(-0500)] <EricDalquist> would you be able to create a jira for that

[16:18:46 CDT(-0500)] <athena> yes

[16:18:49 CDT(-0500)] <EricDalquist> I feel like you have a better handle on that

[16:18:56 CDT(-0500)] <EricDalquist> I'll keep looking for this styles.css class

[16:20:07 CDT(-0500)] <athena> yeah that's weird - i can't find that file at all

[16:21:39 CDT(-0500)] <EricDalquist> oh … it might be from a portlet

[16:21:49 CDT(-0500)] <EricDalquist> I'm still getting use to the chrome dev tools

[16:21:59 CDT(-0500)] <EricDalquist> http://localhost:8080/jasig-widget-portlets/css/styles.css

[16:22:00 CDT(-0500)] <EricDalquist> yup

[16:22:46 CDT(-0500)] <EricDalquist> on the plus side I have SCSS->CSS build time generation working

[16:22:50 CDT(-0500)] <EricDalquist> I'll get it committed on that branch

[16:22:53 CDT(-0500)] <athena> ok, so that's not the portal, at least

[16:22:55 CDT(-0500)] <athena> oh that's awesome (smile)

[16:34:38 CDT(-0500)] <EricDalquist> ok, email sent about build time scss compilation

[16:34:48 CDT(-0500)] <EricDalquist> back on later … of to get shorn

[16:37:02 CDT(-0500)] <athena> cya (smile)

  • No labels